Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ssl for spark connector #18

Merged
merged 5 commits into from
Nov 23, 2021
Merged

support ssl for spark connector #18

merged 5 commits into from
Nov 23, 2021

Conversation

Nicole00
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #18 (81ee547) into master (3124ea9) will decrease coverage by 2.47%.
The diff coverage is 53.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
- Coverage     76.49%   74.02%   -2.48%     
- Complexity      151      152       +1     
============================================
  Files            22       24       +2     
  Lines          1468     1567      +99     
  Branches        228      247      +19     
============================================
+ Hits           1123     1160      +37     
- Misses          206      264      +58     
- Partials        139      143       +4
Impacted Files Coverage Δ
...scala/com/vesoft/nebula/connector/NebulaEnum.scala 100.00% <ø> (ø)
...om/vesoft/nebula/connector/ssl/SSLSignParams.scala 0.00% <0.00%> (ø)
...vesoft/nebula/connector/nebula/GraphProvider.scala 52.38% <21.42%> (-11.26%) ⬇️
.../vesoft/nebula/connector/nebula/MetaProvider.scala 66.03% <23.52%> (-23.16%) ⬇️
...in/scala/com/vesoft/nebula/connector/package.scala 59.25% <36.36%> (-8.72%) ⬇️
...ebula/connector/reader/NebulaPartitionReader.scala 74.39% <36.66%> (-22.11%) ⬇️
...ala/com/vesoft/nebula/connector/NebulaConfig.scala 79.15% <61.90%> (+2.36%) ⬆️
...la/com/vesoft/nebula/connector/NebulaOptions.scala 85.05% <90.90%> (+0.35%) ⬆️
...t/nebula/connector/reader/NebulaSourceReader.scala 93.10% <100.00%> (+0.65%) ⬆️
...cala/com/vesoft/nebula/connector/ssl/SSLEnum.scala 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3124ea9...81ee547. Read the comment docs.

@Nicole00 Nicole00 requested a review from HarrisChu November 18, 2021 11:30
@Nicole00 Nicole00 merged commit 43d1158 into vesoft-inc:master Nov 23, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisChu HarrisChu HarrisChu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nicole00 @codecov-commenter @HarrisChu